Common CSS Mistakes/putting a stop to them

Common CSS Mistakes/Putting a Stop to Them

In the margins of the html5 and css3 rise one can find a whole lot of unpleasantness. Take your eyes away from the dazzling new features for just a couple of seconds and you’ll be overwhelmed by a penetrating stench coming from underneath your browser’s canvas. But that’s not even the worst of it, take some time to look around and notice how badly written css is still very prevalent on the web. Time to get rid of that ugliness first.
It’s obvious there still isn’t a very good base for css best practices. Newcomers to css continue to make the same mistakes we made 10 years ago and with people flocking to html5 and css3 this group is growing fast. It’s a sad state of affairs that needs dealing with, so even though I’m not much of a fan of haphazardly thrown together lists here’s my top list of css ugliness I never want to see again.

1. Stop Unnecessary Floating

.selector {float:left; width:100%;}

The code above is something you find quite often. A simple block level element that is floated with a width of 100% to make it span the complete width of its parent. In most cases, removing the float and width will result in exactly the same rendering, only with more flexible use of margins and paddings. So what gives?
What usually happens is people fail to understand the workings of collapsing margins. Floating the element triggers a more understandable use case where margins are not collapsing with margins of surrounding elements. This is okay until you need to add paddings, margins or extra positioning rules. Furthermore, this code isn’t very browser-proof and you’ll often end up with nasty ie6 troubles.

2. Margins and Paddings

.parent {margin:1em 0.5em 0em 0.5em; padding:0em 0.5em 1em 0.5em;}

Margins and paddings should never be used together to create one single space. Both properties can be placed on leafs (an html element with no children) in certain circumstances, but apart from this use case it’s better to stick with either one of the two to define all spacing around an element.
Usually statements like these come forth of laziness or bad planning. They are the result of last minute changes or unfocused code weaving. All understandable excuses, but if you claim to have a professional attitude you just can’t leave them in your code.

3. Width Abuse

.parent {width:50em;}  .parent .child {width:49em;}  

Use widths only when really necessary. People tend to go all math on their css while css is (somewhat) equipped to do most of the work for you. In the example above, the width declaration on the .child is completely unnecessary. It would be much better to simply add a right margin on the .child element (unless you’d really want the child to be 49em wide independent of the width of its parent). Using paddings or margins instead will ensure decent rendering even when the parent would change widths.
I’ve had several projects where the goal was to widen a site. It’s true bliss if you can do this by adapting just a couple of values in the css without worrying to much about browser inconsistencies. A project like that turns into hell on earth when each component has a specific width defined, especially when these components just take up the available width anyway. It really makes the difference between an hour work or two days of hard labor.

4. Mending and Fixing

.selector {margin-left:-6px;}

There aren’t too many things the web design community as a whole agrees on, but when it comes to ie6 most (if not all) people agree that it is an outdated, hard to code for piece of software junk. And while I won’t contest that statement, it must be said that most of ie6’s problems can be fixed quite consistently. Whether you use inline hacks or conditional comments doesn’t even matter, how you actually go about fixing these issues is more important.
Many of ie6’s bugs exist of (little) misplacements of elements. Most people try to fix these issues by re-aligning them specifically for ie6. For example, if an extra 6px space is added to the left you can counter it by defining a negative margin of the same size. This is crap coding though, as you’re only just mending the problem rather than really fixing it. ie6 might be a true bitch, but most of its bugs can be countered as to make it behave like other browsers.

5. Reset Without Rereset

* {margin:0; padding:0;}

I have nothing against reset css, be it coming from a standard script or coming from custom coding. As long as you make sure to set the general styles back, I’m fine with it. I do get furious when encountering a css where simple text paragraphs don’t even have a margin (or padding) defined on them. This is simply not done and extremely sloppy coding.
So use these reset css styles as much as you like, just make sure to set the basic styles again. Make sure your paragraphs look like paragraphs and lists feature some kind of list element indications. These quick resets eliminate styles that are important for displaying general data, not setting them back to a good standard is pure amateurism.


Basic as these five remarks might be, you’d be surprised how many front-end developers still make mistakes like these. There are many reasons that seem to fuel this state of affairs, like lack of proper schooling or a good fall-back place for css best practices to go to when starting out with css. Most people learn from scattered blogs and snippets found in articles, which is probably not the best way to get to the bottom of what we do. This makes finding a good solution a pretty tough task though.
The list above is more than just my top 5 of commonly seen css ugliness, it’s hopefully a wake-up call to whoever feels the passion and energy to create some kind of starter’s platform for css best practices. Through all the bling and sex of css3 these issues are once again eclipsed, but they might be even more relevant than two years ago with a whole new group of people starting to learn the tricks and trades of html and css.
So no more, it’s time to take css to its next level. And no, I’m not talking modular css or advanced animation, just a good set of best practices and a well considered starters platform for people to get started.

Written by Arvind Bhardwaj

Arvind is a certified Magento 2 expert with more than 10 years of industry-wide experience.